Skip to content

[KeyVault] Work around for authentication failure in Azure Stack using ADFS - #1465

Merged
schaabs merged 1 commit into
Azure:masterfrom
schaabs:adfs-authscheme-workaround
Sep 22, 2017
Merged

[KeyVault] Work around for authentication failure in Azure Stack using ADFS#1465
schaabs merged 1 commit into
Azure:masterfrom
schaabs:adfs-authscheme-workaround

Conversation

@schaabs

@schaabs schaabs commented Sep 22, 2017

Copy link
Copy Markdown

Hard coded Authorization header auth-scheme to 'Bearer' to work around a server side bug in validating the Authorization header

…nd a server side bug in validating the Authorization header
@codecov-io

codecov-io commented Sep 22, 2017

Copy link
Copy Markdown

Codecov Report

Merging #1465 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1465   +/-   ##
=======================================
  Coverage   55.11%   55.11%           
=======================================
  Files        3411     3411           
  Lines       83376    83376           
=======================================
  Hits        45956    45956           
  Misses      37420    37420
Impacted Files Coverage Δ
.../azure/keyvault/custom/key_vault_authentication.py 39.02% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfb1305...cdd7053. Read the comment docs.

@lmazuel lmazuel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schaabs
schaabs merged commit f47d2f6 into Azure:master Sep 22, 2017
@schaabs
schaabs deleted the adfs-authscheme-workaround branch September 22, 2017 17:28
BigCat20196 pushed a commit to BigCat20196/azure-sdk-for-python that referenced this pull request Sep 14, 2022
…eration

support dpg for sdk generation pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants